That's dangerous! You need to know a lot for that not to go wrong (especially if TR is involved)!
That can certainly go wrong, but right now, if you edit some part of
collects/racket and then run a file, it runs pretty fast, but if you run
racket -y thatfile.rkt it will take a long time. I tried the following:
- create x.rkt with just
- run it. takes about .8 seconds on my laptop.
- run x.rkt again. About 1.4 seconds.
racket -y x.rkt. Took over 2 minutes.
I agree that this is potentially dangerous but it's something that works now and people do similar things regularly, and it will take a long time with
-y. So it's a thing people should be aware of.
I'm unreasonably excited for this
I'm almost there. I'm having trouble imagining under what circumstances B_rkt.zo could be used after a change to C.rkt. Isn't it possible that the change to 'C.rkt' introduces some new binding—especially a macro binding—that will change the meaning of B.rkt, and wouldn't it be almost impossible to figure that out without compiling C.rkt? Does racket have a system that can do enough of compilation to determine that the changes to C.rkt don't affect the meaning of B.rkt? I see from your example that this is a real effect, I'm just trying to figure out how it works.
Taking "dramatically" out, I now have these two possible wordings for this item:
-yflag automatically keeps compiled files up to date,
reducing load times.
Racket includes a new flag (
-y) that automatically stores a compiled
version of the code being run.
I agree that the first one does a better job of communicating why you might want this, but I'm slightly concerned by Sam's examples of outlier examples where it might hurt.
Historically, we've used the word "now" way too much. The word "new" hasn't been as much of a problem, I believe.
Either way, I added your bullet and just deleted the word "now", hope that's okay.
Ah - I wondered if it was for a deeper philosophical reason. Either way, that’s great, many thanks!
Maybe “potentially reducing load times”?
— Sharon Tuttle
I think "reducing subsequent load times" is the right change.
Yes, it's definitely possible that this produces entirely the wrong behavior. And there is no protection against it. That's what @robby means by "dangerous". But the alternatives are somewhat unpalatable (my experiment is an error, or takes multiple minutes, or skips using compiled code and takes potentially even longer) so that's what we've stuck with.
I also think the release notes should have a note about Zlib and whatever users need to know.
Do you have time to draft a note on this?
The intent here is to allow Racket CS to run on any platform where Racket BC runs — including platforms where Racket CS has no machine-code backend, which is a subset of platforms where Racket BC has no JIT. Run time for Racket code in CS without a machine-code backend is similar to run time in BC without a JIT, although compilation times are still slower in the CS variant (because the Racket BC bytecode compler is implemented directly in C, instead of compiled from Scheme to "portable bytecode" to C).
Here's a suggested rewording to say more:
- Racket CS runs on platforms where native-code generation is not currently supported (e.g., s390x or ppc64). See "README.txt" in the source distribution for more information on the
Here's an attempt—the key question is whether this all is, in fact, true, and then whether there is a shorter or clearer way to say it.
- Racket CS incorporates Zlib 1.2.11, which is affected by CVE-2018-25032. If Racket CS is configured to use Zlib compression for compiled code—which is not the default—compiling a specially crafted source file could potentially cause memory corruption, denial of service, or arbitrary code execution. The vulnerability does not affect decompression (i.e. loading compiled code). Racket BC does not use Zlib, and thus is unaffected. Likewise, the
file/gzipmodule implements “deflate” compression in pure Racket, without using Zlib. When building Racket from source, Racket CS can be linked with a fixed copy of Zlib, instead of the included copy, by supplying appropriate flags to
configure. We expect to update Racket's copy of Zlib in the next Racket release.
Some parts that are a bit squishy:
Racket CS incorporates Zlib: My current tentative understanding is that it always links to Zlib, whether statically or dynamically, even if it does not use it.
If Racket CS is configured to use Zlib compression: The main sense is configuring with
configure, and it might be more clear to just talk about that. I suspect (but do not know) that there may be some way to use
ffi/unsafe/vmto set parameters at run time, but if an attacker can use
ffi/unsafe/vm, why bother with Zlib?
which is not the default: The aim is to communicate that Racket is not configured to use Zlib compression by default, but also to say so without confusing anyone who has followed this bug too closely. (Initially, it was thought to affect only compression with
Z_FIXED, which is not Zlib's default, but it turned out to also affect
Here's my shortened attempt:
- Those who manually configure Racket CS to use Zlib compression for compiled code should be aware of CVE-2018-25032, which could potentially open the door to a host of attacks.
Here's my shortened attempt:
Those who manually configure Racket CS to use Zlib compression for compiled code should be aware of CVE-2018-25032, which could potentially open the door to a host of attacks.
Here's an edit to consider:
"Those who manually configure Racket CS to use Zlib compression for compiled code should be aware of CVE-2018-25032; the next release and the current snapshot builds use a newer version of zlib."
Sounds good to me.
Ooh, have to get to 20 characters.
It looks like there's also now NVD - CVE-2022-37434, which affects the updated zlib 1.2.12 (which is still the latest release).
What is the normal approach?
If users identify this as a risk for them should they update zlib themselves and build from source until the next release?
(I’m guessing the last zlib update could be used as a guide? Chez Scheme: update zlib to v1.2.12 · racket/racket@2100cea · GitHub )
At first glance, it doesn't look like
inflateGetHeader is used in Chez Scheme. (It might be possible to get to it via
ffi/unsafe functionality, but, if you can run unsafe Racket code, you can already do arbitrarily bad stuff.) However,
In addition to the Zlib used by Chez Scheme, Zlib is also included on some platforms with the support libraries for
racket/draw: see Zlib for `racket/draw` affected by CVE-2018-25032 · Issue #4286 · racket/racket · GitHub.
I started working on a script at one point to check for CVEs during CI; I'll try to get back to that.